cvs commit: src/sys/boot/i386/boot2 boot1.S sio.S src/sys/boot/i386/btx/btx btx.S src/sys/boot/i386/btx/btxldr btxldr.S src/sys/boot/i386/libi386 amd64_tramp.S src/sys/boot/i386/pxeldr pxeldr.S

John Baldwin jhb at
Wed Apr 28 08:08:39 PDT 2004

On Wednesday 28 April 2004 10:31 am, Ruslan Ermilov wrote:
> ru          2004/04/28 07:31:44 PDT
>   FreeBSD src repository
>   Modified files:
>     sys/boot/i386/boot2  boot1.S sio.S
>     sys/boot/i386/btx/btx btx.S
>     sys/boot/i386/btx/btxldr btxldr.S
>     sys/boot/i386/libi386 amd64_tramp.S
>     sys/boot/i386/pxeldr pxeldr.S
>   Log:
>   After talking to Bruce Evans and reading more standards specs,
>   switch to using C99-style comments everywhere in preprocessed
>   assembler.  The reason is that lines starting with the regexp
>   '^[[:space:]]#' are treated as preprocessing directives, and
>   while it seems to work now with GCC, it's not necessarily has
>   to work.  Use C99 comments `//' for the trailing comments to
>   save whitespace.

Well, that just killed any local diff's anyone had to the boot code for a 
trivial reason.  as(1) worked just fine, I don't see why it's such a cardinal 
sin to use as(1) to compile asm files.

Thanks for not even asking before hosing the history in cvs annotate:

> grep jhb /usr/src/MAINTAINERS
cdboot          jhb     Pre-commit review requested.
pxeboot         jhb     Pre-commit review requested.
witness         jhb     Pre-commit review requested.
sys/boot/i386/cdboot/Makefile:MAINTAINER=       jhb at
sys/boot/i386/pxeldr/Makefile:MAINTAINER=       jhb at

John Baldwin <jhb at>  <><
"Power Users Use the Power to Serve"  =

More information about the cvs-src mailing list