cvs commit: src/sys/dev/acpica acpi_pci.c src/sys/dev/pci pci.c

[John Baldwin]

On Sunday 25 April 2004 10:11 pm, Warner Losh wrote:
> imp         2004/04/25 19:11:38 PDT
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/dev/acpica       acpi_pci.c
>     sys/dev/pci          pci.c
>   Log:
>   Fix two typos from PR: 65694
>
>   1) In pci.c, we need to check the child device's state, not the parent
>      device's state.
>   2) In acpi_pci.c, we have to run the power state change after the acpi
>      method when the old_state is > new state, not the other way around.

Umm, the ACPI method may turn the power to the device off (i.e., turn off the 
power resource that provides power to the device), meaning that you can't 
access it's PCI config registers anymore.  It's quite intentional to turn the 
device off using PCI first and ACPI second and then to turn the device on via 
ACPI first and then PCI second.

Unfortunately, the PR number is wrong (that's some ports PR) and there are no 
PR's in the database with an originator that contains 'Remesov' or the text 
'acpi_pci' in the text fields at least none that query-pr-summary.cgi can 
find.  Ugh, actually, query-pr is just hosed as it thinks we have no open 
PRs.  *sigh*

>   Submitted by: Dmitry Remesov
>   PR: 65694
>
>   Revision  Changes    Path
>   1.14      +1 -1      src/sys/dev/acpica/acpi_pci.c
>   1.249     +1 -1      src/sys/dev/pci/pci.c

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org