cvs commit: src/sys/net radix.c

Darren Reed darrenr at
Wed Apr 21 17:21:43 PDT 2004

On Thu, Apr 22, 2004 at 01:03:42AM +0100, Colin Percival wrote:
> At 00:24 22/04/2004, Darren Reed wrote:
> >Some of these changes, for the sake of change, can be annoying...
>   As Luigi mentioned when he started this, these aren't changes "for the
> sake of change"; rather, these are changes to clean things up so that it
> is easier to add all the necessary locking.

Uh, really?
Changing variable names is required to make locking easier?
Changing "x = *(u_char *)p" into "x = LEN(p)" makes locking easier?

In the end, if someone decides that the code needs to be restructured
for better performance in SMP hardware, then that's what'll happen and
changes like these will have little significance at that point in time.


More information about the cvs-src mailing list