cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c

Roman Kurakin rik at
Fri Apr 16 04:31:37 PDT 2004

Søren Schmidt wrote:

>> Includes fixes to avoid checking the ATA_FLAG_54_58 bit, fixing LBA
>> detection:
>> Submitted by:    rk
> not true, rk submitted the problem not the code.

Probably you are talking about me "rik" :-)
I realy doesn't submit any code. I just tell my suggestions that 
checking this bit
is bad idea according to ata spec, and according last ata specs it 
shouldn't be
used at all since it obsoleted. So I didn't submit any fixes about it. 
Only idea.
So this may be "Asked by" or "Pointed by" :-)

Code I submitted was to make ata driver more verbose about CHS mode.
They still are not there and should be revised to make them possible to
apply to current code.

By the way, may be it would be a nice idea to warn users that they have
ATA_FLAG_54_58 bit off, and device will work in LBA mode not
in CHS as was before?


More information about the cvs-src mailing list