cvs commit: src/sys/kern kern_timeout.c src/sys/sys
callout.h src/share/man/man9 timeout.9
colin.percival at wadham.ox.ac.uk
Tue Apr 6 16:53:34 PDT 2004
At 00:32 07/04/2004, Nate Lawson wrote:
>For this one, you can move the comment to above the "if" statement and add
>a blank line before it. It's usually best to comment on the whole block
>above the if statement rather than within it.
Hmm... those comments are written in the context of the "if" blocks. Does
it really make sense to replace
/* Bar */
/* If foo, then bar */
I'm generally happy to make style changes, but this seems like a rather
peculiar change to make.
>> int callout_stop(struct callout *);
>> +#define callout_stop(c) _callout_stop_safe(c, 0)
>The goal here is to keep binary compatibility (multiple defines of
The goal was binary compatibility; the callout_stop prototype was
still here because gcc complained while compiling kern_timeout.c
otherwise. If there's a better solution, please let me know.
>going to remove that shim at some point? Perhaps a BURN_BRIDGES or
>GONE_IN_6 ifdef would be appropriate for that.
I think this shim can be removed as soon as any modules which know
about callout_stop have been recompiled; I doubt it will take long
before someone makes a change which requires that to happen. :-)
More information about the cvs-src