cvs commit: src/sys/dev/sio sio.c
bde at FreeBSD.org
Sat Sep 27 04:14:01 PDT 2003
bde 2003/09/27 04:14:00 PDT
FreeBSD src repository
Cleaned up and fixed setting of speeds in comparam():
- Removed conversion of a zero input speed to the output speed. This
has been done better in ttioctl() since rev.1.108 of kern/tty.c
almost 5 years ago. comparam() did the conversion incompletely for
the case where the output speed is also zero. It had complications
to avoid using zero speeds, but would still have used a zero input
speed for setting watermarks if kern/tty.c had passed one.
- Never permit the input speed to be different from the output speed.
There was no validity check on the input speed for the case of a zero
output speed. Then we didn't change the physical speeds, but we used
the unvalidated input speed for setting watermarks and didn't return
an error, so ttioctl() stored the unvalidated input speed in the tty
struct where it could cause problems later.
- Removed complications that were to avoid using a divisor of 0. The
divisor is now always valid if the speed is accepted.
Revision Changes Path
1.413 +20 -31 src/sys/dev/sio/sio.c
More information about the cvs-src