cvs commit: src/sys/pci if_sis.c if_sisreg.h

Poul-Henning Kamp phk at phk.freebsd.dk
Thu Sep 4 01:35:30 PDT 2003


In message <1062663414.86530.15.camel at herring.nlsystems.com>, Doug Rabson write
s:

>For specific drivers, if they really want to change the device
>description in attach (why not do it in probe like every other driver),

In the case of the sis driver, the "silicon revision register" is
stored somewhere in BAR0, so I cannot examine it until the resources
are allocated.

I know there are other drivers which could be similarly more detailed
of the description were set in attach rather than probe.

I think postpoining the print to after attach might make sense.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the cvs-src mailing list