cvs commit: src/sys/netinet tcp_syncache.c

Mike Silbersack silby at silby.com
Tue Nov 11 12:09:35 PST 2003


On Tue, 11 Nov 2003, Jeffrey Hsu wrote:

> Asking nicely for a more verbose clarification of a commit message this
> is too short is perfectly fine and reasonable.  Demanding an immediate
> backout without justification is an entirely different matter.  It's
> just plain bullying.
>
> 							Jeffrey

Technically, your original change was correct, since syncache_respond
turned out not to have complete locking...

... also technically, sam didn't back out your change, he switched the
MPSAFEness to be dependent on the debug_mpsafenet flag, so that it would
only be MPSAFE for those who took the risk...

... and Sam had some assertions and fixes in p4 which he was planning to
commit to CVS, but hadn't gotten to yet...

So, let's all just agree that things got a bit desynchronized and drop
this, it's not worth our time to argue over a one line change.

Mike "Silby" Silbersack


More information about the cvs-src mailing list