cvs commit: src/bin/ls extern.h ls.c print.c util.c src/bin/pax ar_io.c ar_subs.c cache.c cpio.c extern.h gen_subs.c getoldopt.c options.c pat_rep.c pax.c pax.h src/bin/ps fmt.c src/bin/rcp rcp.c

[David O'Brien]

On Sun, May 04, 2003 at 03:43:53PM +0300, Giorgos Keramidas wrote:
> On 2003-05-03 18:17, David O'Brien <obrien at FreeBSD.org> wrote:
> >On Sun, May 04, 2003 at 12:44:27AM +0300, Giorgos Keramidas wrote:
> >>: giorgos at gothmog[00:36]/a/freebsd/src/bin/ps$ rm print.o
> >>: giorgos at gothmog[00:36]/a/freebsd/src/bin/ps$ make WARNS=0 print.o
> >>: cc -O2 -Wall -pipe -DLAZY_PS    -c print.c
> >>: print.c: In function `started':
> >>: print.c:405: warning: `%y' yields only last 2 digits of year
> >>: print.c: In function `lstarted':
> >>: print.c:422: warning: `%c' yields only last 2 digits of year in some locales on non-BSD systems
> >>:
> >>: giorgos at gothmog[00:36]/a/freebsd/src/bin/ps$ rm print.o
> >>: giorgos at gothmog[00:36]/a/freebsd/src/bin/ps$ make WARNS=1 print.o
> >>: cc -O2 -Wall -pipe -DLAZY_PS   -Wsystem-headers -Werror  -c print.c
> >>...
> >> The warnings are a result of -Wformat-y2k, which is included in -Wall:
> >
> > Why doens't WARNS=1 give you "-Wall -Wno-format-y2k" as it is supose to?
> 
> WARNS=1 doesn't include -Wno-format-y2k, if I'm reading bsd.sys.mk correctly:

You are correct, sorry.  But the meat of it is how are you getting -Wall
and not -Wno-format-y2k?
 
>                        30: .  if ${WARNS} > 1
>   1.8       obrien     31: CFLAGS         +=      -Wall -Wno-format-y2k
>   1.4       obrien     32: .  endif

As you can see, they come paired together.


> > Do you have some local settings in /etc/make.conf??
> 
> Nothing important there.  The most relevant local changes shown by
> `diff -u /usr/share/examples/etc/make.conf make.conf' are:
> 
>   +NO_CPU_CFLAGS= true    # Don't add -march=<cpu> to CFLAGS automatically
>   +NO_CPU_COPTFLAGS=true  # Don't add -march=<cpu> to COPTFLAGS automatically
>    ...
>   -#CFLAGS= -O -pipe
>   +CFLAGS?= -O -pipe
>    ...
>   -#COPTFLAGS= -O -pipe
>   +COPTFLAGS?= -O -pipe

How are you getting -O2 above?