cvs commit: src/sys/vm uma_core.c

Julian Elischer julian at elischer.org
Mon Jun 9 15:42:53 PDT 2003



On Mon, 9 Jun 2003, Nate Lawson wrote:

> On Mon, 9 Jun 2003, Poul-Henning Kamp wrote:
> >   A white-space nit I noticed.
> >
> >   Revision  Changes    Path
> >   1.56      +1 -1      src/sys/vm/uma_core.c
> >
> > --- src/sys/vm/uma_core.c:1.55	Sun Apr 27 23:11:32 2003
> > +++ src/sys/vm/uma_core.c	Mon Jun  9 12:40:34 2003
> > @@ -1843,7 +1843,7 @@
> >
> >  	/* Do we need to remove from any lists? */
> >  	if (slab->us_freecount+1 == zone->uz_ipers) {
> > -		LIST_REMOVE(slab, us_link);
> > +		LIST_REMOVE(slab,us_link);
> >  		LIST_INSERT_HEAD(&zone->uz_free_slab, slab, us_link);
> >  	} else if (slab->us_freecount == 0) {
> >  		LIST_REMOVE(slab, us_link);
> 
> Is that correct style to remove the space after the comma?  The former way
> seems more correct.  Also, it differs from the LIST_REMOVE immediately
> after.

I am guessing a patch applied backwards or something..
I'm sure that's not what he inteded :-)

> 
> -Nate
> 



More information about the cvs-src mailing list