cvs commit: src/sys/kern subr_witness.c

Poul-Henning Kamp phk at phk.freebsd.dk
Mon Jun 2 12:25:07 PDT 2003


In message <XFMail.20030602152310.jhb at FreeBSD.org>, John Baldwin writes:
>
>On 31-May-2003 Poul-Henning Kamp wrote:
>> phk         2003/05/31 13:09:42 PDT
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/kern             subr_witness.c 
>>   Log:
>>   Remove return after panic.
>>   
>>   Found by:       FlexeLint
>
>revision 1.90
>date: 2001/11/15 19:46:36;  author: jhb;  state: Exp;  lines: +7 -3
>Add a couple of returns to making recovering from a failed witness_assert()
>more sane in the RESTARTABLE_PANICS case.
>
>They were intentional, though perhaps they should have been wrapped
>in #ifdef RESTARTABLE_PANICS.  cvs annotate is your friend. :)

That would be the correct solution.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the cvs-src mailing list