cvs commit: src/sys/pci ncr.c

[Robert Drehmel]

robert      2003/07/26 17:13:50 PDT

  FreeBSD src repository

  Modified files:
    sys/pci              ncr.c 
  Log:
  Changed the type of the variable `qidx' from u_int8_t to int,
  mainly to quiet a warning emitted by GCC 3.3 about comparing
  a variable to a value which is larger than the former can hold.
  
  The value was checked to make sure the `np->squeue' array is
  not accessed behind its boundary.
  This worked due to possibly accidental truncation when
  (np->squeueput + 1) was larger than or equal to MAX_START (256)
  when it was assigned to `qidx'.
  
  `qidx' is used to hold the next position in the start queue
  for an insertion.  The new type was chosen because some other
  code in the function ncr_freeze_devq() also uses plain integers
  to hold those indices.
  
  Wrapped the line after the closing parenthesis of an `if'
  condition.
  
  Revision  Changes    Path
  1.176     +3 -2      src/sys/pci/ncr.c