cvs commit: src/usr.sbin/lpr/lpd lpd.c ...

Alfred Perlstein bright at mu.org
Sun Jul 6 17:32:17 PDT 2003


* Garance A Drosihn <drosih at rpi.edu> [030706 16:17] wrote:
> At 5:44 AM -0700 7/6/03, Philippe Charnier wrote:
> >charnier    2003/07/06 05:44:11 PDT
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    usr.sbin/lpr/lpd     lpd.c
> >    [...etc...]
> >  Log:
> >  add FBSDID
> 
> Speaking only for lpd, I wish you would not have added FBSDID.
> I had started to add FBSDID to all the source files of
> lpr & friends, and found that it was just annoying when I
> then went to build lpr on other platforms.  So, I switched
> back to just plain 'rcsid[] ='.
> 
> It also seems odd to me that you added it to only one source
> file out of the dozens in usr.sbin/lpr.  Is there some reason
> that this one file stood out as needing FBSDID?

Isn't there a common header where you can just add:

#ifndef __FBSDID
#define __FBSDID(s)     struct __hack
#endif

?


More information about the cvs-src mailing list