cvs commit: src Makefile.inc1

Ruslan Ermilov ru at FreeBSD.org
Wed Jul 2 00:35:24 PDT 2003


On Tue, Jul 01, 2003 at 11:43:49AM -0700, David O'Brien wrote:
> On Tue, Jul 01, 2003 at 12:47:57AM +0300, Ruslan Ermilov wrote:
> > +.if exists(${.CURDIR}/rescue) && !defined(NO_RESCUE) && \
> > +    ${BOOTSTRAPPING} < 501100
> > +_crunchgen=	usr.sbin/crunch/crunchgen
> > +.endif
> 
> Why do you need the "exists(${.CURDIR}/rescue)"?  If this code made it to
> Makefile.inc1, src/rescue also made it to the checked out area.
> 
> > +.if exists(${.CURDIR}/rescue) && !defined(NO_RESCUE) || \
> > +    defined(RELEASEDIR)
> > +_crunchide=	usr.sbin/crunch/crunchide
> > +.endif
> 
> Same.  Please simplify the logic.
> 
Because this is consistent with the logic of constructing the
SUBDIR list.  The committed version was ever more complicated,
but we now build these bits ONLY when necessary, as you have
requested some time ago (must admit I like it).


Cheers,
-- 
Ruslan Ermilov		Sysadmin and DBA,
ru at sunbay.com		Sunbay Software Ltd,
ru at FreeBSD.org		FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20030702/e9d1ab6c/attachment.bin


More information about the cvs-src mailing list