cvs commit: src/contrib/gcc/config freebsd-spec.h

[Daniel Eischen]

On Sun, 31 Aug 2003, David O'Brien wrote:

> On Sun, Aug 31, 2003 at 03:38:52PM -0700, Daniel Eischen wrote:
> > deischen    2003/08/31 15:38:52 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     contrib/gcc/config   freebsd-spec.h 
> >   Log:
> >   Remove -pthread as a compiler option.  It was deprecated 2.5 years
> >   ago, but not removed.
> >   
> >   No reply from:  threads, kan, obrien
> 
> Please back this out.

Unlike the patch I sent to you, this doesn't take anything
off a vendor branch; I realized it wasn't necessary.

> I haven't had a chance to reply to you because this is a complicated
> matter.  It also seemed that maybe you wished the patch you sent to be
> forwarded back to the FSF and not committed in our repo.  We can't just

The first part of the patch I sent (gcc/config.gcc) should be
forwarded back to FSF and we can bring it back in from a future
import.  I did not commit that part of the patch.  I only committed
to freebsd-spec.h which I can see from the logs has been modified
at other times without being imported from GCC.

> remove this like this w/o coordinating with the code in the FSF repo.

Sure, we can coordinate, but I don't see a reason to hold
this up when all we are changing is a file that is already
off the vendor branch.  Coordinate all you want, but let's
move on :-)

> {Net,Open}BSD and Linux all accept the "-pthread" option.  By removing
> support for it we are the odd man out on accepted GCC options.  You also

{Net,Open}BSD have it because they had the same problem with
libc_r (it couldn't be linked with libc).  Since when did Linux
get this hack and why?

Why do we have to get stuck with this option and lumped-in
with {Net,Open}BSD and Linux?  Why are not other OSes also in
the same lump?

> break Makefile compatability with FreeBSD 4.x.

How?  libgcc?  It doesn't need -lc_r or -pthread since it
uses weak symbols.

Are we talking about buildworld or ports?  I know we are
breaking 3rd party makefiles, but we need to do that
and knew over 2 years ago.

We need to get rid of this option so we can work on making
our ports work with other threading libraries.

-- 
Dan Eischen