cvs commit: src/sys/dev/fb fb.c

Bruce Evans bde at zeta.org.au
Sat Aug 30 03:20:47 PDT 2003


On Sat, 30 Aug 2003, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote:

> Jake Burkholder <jake at FreeBSD.org> writes:
> >   Log:
> >   Changed ??? to foo in dead code since ??? screws up my editor.
>
> ??? also confuses the compiler ("invalid trigraph blah blah") and
> should be avoided in C code.

Actually, "???" is a valid non-trigraph that doesn't confuse C compilers.
It just sometomes forms a trigraph when mixed with other punctuation.
E.g., "???)" forms the character "?" followed by the trigraph "??)".
So "???)" is converted to "?]" by C compilers.

In fb.c, "???" was followed by ",", so it was just a syntax error (one
of many bugs in the dead code).

Bruce


More information about the cvs-src mailing list