cvs commit: src/sys/libkern arc4random.c

Mike Silbersack silby at
Fri Aug 15 11:42:38 PDT 2003

On Fri, 15 Aug 2003, Sam Leffler wrote:

> >   Lock down arc4random so it can be safely called w/o Giant.
> >
> >   Minor code reorganization was required, but the only functional
> >   change was that the first 1024 bytes of output are thrown out
> >   after each reseed, rather than just the initial seed.
> How did you validate the this change?  I strongly suggest that mods like
> this need review before commit.  Subtle problems can go unnoticed for a
> long time.
> 	Sam

I'm fairly confident that I did not add any bugs in this commit.  However,
I also have no way of knowing if arc4random was working correctly before
the commit either... How hard would it be to hook up the randomness
testing code you committed a few months back?  If the testing code is in
userland, perhaps we could export a /dev/arandom like openbsd does for
simpler testing.

Mike "Silby" Silbersack

More information about the cvs-src mailing list