cvs commit: src/sbin/growfs debug.c debug.h

[Lukas Ertl]

On Thu, 14 Aug 2003, Nate Lawson wrote:

> On Thu, 14 Aug 2003, Lukas Ertl wrote:
> > On Thu, 14 Aug 2003, Nate Lawson wrote:
> >
> > > On Thu, 14 Aug 2003, Robert Watson wrote:
> > > >   Modified files:
> > > >     sbin/growfs          debug.c debug.h
> > > >   Log:
> > > >   Commit 1 of 2 to fix ffsinfo(8) for UFS2.
> > >
> > > Nice.  I have been working on UFS2 support for growfs so if you have any
> > > work in that area, let me know.  Most of it is sblock-related.
> >
> > I wasn't aware that growfs has issues with UFS2.  What are the problems?
>
> The number one problem is the code sucks.  No one is willing to maintain
> it because of this.

Oh. :-)

> The number two problem is that not enough testing has been done with
> growfs on UFS2.  Feel free to do this and report any problems.

I've successfully grown UFS2 filesystems residing on vinum volumes in the
past, but I didn't do I regularly.

> The actual problem I am addressing is larger than growfs.  Basically, any
> time a sblock change is made, every UFS utility in the system has to be
> updated and growfs has not kept up.  So I have extracted sblock updating
> into a routine that is shared between the kernel and userland so that it's
> only in one place in the code.  But more work is needed before it can be
> committed.

Well, I'd say that libufs is already a right step in this direction.  I
would have already patched growfs to use libufs, but growfs somehow seems
a little bit too much like voodoo. :-)

regards,
le

-- 
Lukas Ertl                             eMail: l.ertl at univie.ac.at
UNIX Systemadministrator               Tel.:  (+43 1) 4277-14073
Vienna University Computer Center      Fax.:  (+43 1) 4277-9140
University of Vienna                   http://mailbox.univie.ac.at/~le/