cvs commit: src/rescue/rescue Makefile

[Gordon Tetlow]

On Sat, Aug 02, 2003 at 12:11:56AM +1000, Bruce Evans wrote:
> On Fri, 1 Aug 2003, Gordon Tetlow wrote:
> 
> > gordon      2003/08/01 02:04:32 PDT
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     rescue/rescue        Makefile
> >   Log:
> >   When using crunchgen, blow away MAKEFLAGS. This fixes make -j <#> -P
> >   from passing the -P flag to crunchgen which seems to confuse crunchgen
> >   horribly.
> 
> Doesn't also prevent make -j <#> -P from passing the -j <#> flag and any
> other useful flags that may be in MAKEFLAGS?

That's true, but it's only on a single invocation of crunchgen. I should
have been more clear in my commit message.

> >   This is the preferable solution to modifing crunchgen to
> >   unset the MAKEFLAGS environment variable.
> 
> Certainly, since unsetting MAKEFLAGS very generally would be more likely
> to lose something important in it.
> 
> Setting MAKEFLAGS to ${MAKEFLAGS:N-P} might be safe enough to do generally.

I'll test out this solution. There are other flags that are potentially
dangerous (perhaps -v, although I haven't tested it to see if it causes
problems).

-gordon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20030801/1b0f89af/attachment.bin