cvs commit: src/sys/alpha/osf1 osf1_signal.c

[John Baldwin]

On 28-Apr-2003 Alan L. Cox wrote:
> John Baldwin wrote:
>> 
>> On 26-Apr-2003 Alan L. Cox wrote:
>> > John Baldwin wrote:
>> >>
>> >> jhb         2003/04/25 12:52:30 PDT
>> >>
>> >>   FreeBSD src repository
>> >>
>> >>   Modified files:
>> >>     sys/alpha/osf1       osf1_signal.c
>> >>   Log:
>> >>   Lock Giant around calls to useracc() in osf1_sigreturn() so that the
>> >>   function is MP safe.
>> >>
>> >>   Revision  Changes    Path
>> >>   1.31      +5 -1      src/sys/alpha/osf1/osf1_signal.c
>> >
>> > The calls to useracc() should simply be eliminated because they are
>> > redundant.  See, for example, any of the implementations of sigreturn in
>> > alpha/alpha/machdep.c.
>> 
>> I don't mind if they are removed. :)
>> 
> 
> Is that a subtle suggestion for me to do it?  :-)

Heh, if you want.  At the moment I'm working on pushing Giant down
(or eradicating it) from syscalls centered around process things
such as signalling, etc.  I figured the useracc() checks could be
axed but chose to play it safe.  I'd rather have someone more
knowledgeable in the VM area axe them. :)

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/