cvs commit: src/sys/dev/fxp if_fxp.c

Matthew N. Dodd mdodd at FreeBSD.ORG
Tue Apr 15 07:51:50 PDT 2003


On Tue, 15 Apr 2003, M. Warner Losh wrote:
> How do you tell if a BAR is enabled?  I assume you mean 'check to see
> if the BAR has an allocated resource' here?  In that case, my XXX
> applies :-(  We should allocate a resonable resource.

Actually I misspoke; we should modify pci_enable_io_method() so that we
can indicate a failure to enable the requested space.

This would keep drivers from having to check and see if PCIM_CMD_PORTEN or
PCIM_CMD_MEMEN is set.

This requires changing the definition of the 'enable_io' method.

Since we're here we should change 'disable_io' and
'{enable,disable}_busmaster' as well.

--
| Matthew N. Dodd  | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD  |
| winter at jurai.net |       2 x '84 Volvo 245DL        | ix86,sparc,pmax |
| http://www.jurai.net/~winter |  For Great Justice!  | ISO8802.5 4ever |


More information about the cvs-src mailing list