cvs commit: src/bin/ps keyword.c print.c ps.h

[Greg 'groggy' Lehey]

On Tuesday, 15 April 2003 at 18:48:15 +1000, Tim Robbins wrote:
> On Tue, Apr 15, 2003 at 02:36:07PM +0930, Greg 'groggy' Lehey wrote:
>
>> On Saturday, 12 April 2003 at  3:39:56 -0700, Tim J. Robbins wrote:
>>> tjr         2003/04/12 03:39:56 PDT
>>>
>>>   FreeBSD src repository
>>>
>>>   Modified files:
>>>     bin/ps               keyword.c print.c ps.h
>>>   Log:
>>>   Display residency and sleep times (re and sl fields) larger than 127 as 127.
>>>   This is what the manual page says ps should do, and what OpenBSD and NetBSD do.
>>
>> Why is this a Good Thing?
>
> Two reasons: it makes the output of "ps -v" less ugly, and it makes the code
> consistent with the documentation.

"This is the way we've documented it, so this is the way it has to be" :-)

> It's a waste of information though. What do you suggest instead?
> Dynamically resizing the column width to fit the number would be one
> alternative.

Yes, I checked the options before I replied.  If it's just a matter of
column width, I'd suggest going to 999 and replacing larger values
with the text ">1K", which is the same width.  But maybe dynamic
resizing would make more sense.

I wonder why the other BSDs do it this way.  I can't imagine that it
was a very conscious decision.  Could it be that at some point the
value was never larger (signed char)?

Greg
--
See complete headers for address and phone numbers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20030415/9e8be26d/attachment.bin