cvs commit: src/sys/cam/scsi scsi_da.c

[Nate Lawson]

On Sat, 12 Apr 2003, Poul-Henning Kamp wrote:
>   Modified files:
>     sys/cam/scsi         scsi_da.c 
>   Log:
>   Remove the unused ioctl routine.
>   
>   Revision  Changes    Path
>   1.137     +0 -32     src/sys/cam/scsi/scsi_da.c
>
> -static int
> -daioctl(struct disk *dp, u_long cmd, void *addr, int flag, struct thread *td)
> -{
> -	error = cam_periph_ioctl(periph, cmd, addr, daerror);

Uh, tell me who is going to call cam_periph_ioctl()?  This is necessary
to allow camcontrol to get a passthrough device.  All the other drivers
call it.

What bothers me is that you don't pay attention to MAINTAINERS:
>CAM   gibbs,
>      ken     Pre-commit review requested. send to scsi at freebsd.org

I don't think you'd be happy if I picked a random, seemingly unused
function in geom and nuked it, apparently without understanding the
impact.  Please be considerate of others.

-Nate