cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c

[David O'Brien]

On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote:
> -.  if ${WARNS} > 4
> +.  if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
>  CFLAGS		+=	-Wuninitialized
>  .  endif

Why not just get rid of it totally?  We have this already:

    .  if ${WARNS} > 1 && ${WARNS} < 5
    # XXX Delete -Wuninitialized by default for now -- the compiler doesn't
    # XXX always get it right.
    CFLAGS      +=  -Wno-uninitialized
    .  endif

so we already know it is problematic.  OR rather than use:

    .  if ${WARNS} > 4 
    CFLAGS      +=  -Wuninitialized
    .  endif

use

    .  if ${WARNS} == 4 
    CFLAGS      +=  -Wuninitialized
    .  endif