cvs commit: ports/graphics/opennurbs Makefile pkg-plist

[Chris Rees]

On 22 March 2012 17:49, Michael Scheidell <scheidell at freebsd.org> wrote:
> On 3/19/12 11:43 PM, Doug Barton wrote:
>>
>> On 3/19/2012 7:29 PM, Wesley Shields wrote:
>>>
>>> On Mon, Mar 19, 2012 at 10:32:44AM -0400, Michael Scheidell wrote:
>>>>>
>>>>>
>>>>> On 3/19/12 10:30 AM, Wesley Shields wrote:
>>>>>>>
>>>>>>> Isn't it better to use ${INSTALL_DATA} here?
>>>>>>>
>>>>>>> -- WXS
>>>>>
>>>>> open a pr, let maintainer approve it.
>>>
>>> As the person who committed this it is your responsibility to see that
>>> issues raised are properly fixed. If you feel like the maintainer should
>>> be brought in for such a simple change that is your decision to make,
>>> but I shouldn't have to open a PR to address this.
>>
>> +1
>>
>>
> yeh doug, like this one?
>
> which I sent to you privately, after you editied makefile and redid how
> PORTDOCS worked by changing it to the macro? weren't you the last committer?
> <http://www.freebsd.org/cgi/query-pr.cgi?pr=165167>  oh, and not only the
> last committer, but you wrote the actual patch!
>
> Look what you left on the filesystem after pkg deleted because you didn't
> look at the Makefile and see the obvious mistake:
>
> <http://people.freebsd.org/~scheidell/smartmontools-5.42_3.log>
>
> Don't you ever test your patches first?
>
> Have some common courtesy, all of you.  I will continue to privately send a
> patch to a member of our team, and, offer to open a PR if they insist.
> (i opened a pr <http://www.freebsd.org/cgi/query-pr.cgi?pr=165670>  March
> 3rd, after sending Doug a private email on Feb 27th.  He finally got back to
> me and told me to open a pr.. I didn't send a public flogging email
> demanding that at the last committer he fix it, and, I would not have,
> hoping that by example, he would maybe learn that a quick, private email,
> with a patch, or suggestion, or real explanation of the problem was better
> than public flogging.
>
>  Even if I get cryptic emails demanding I fix something and am never told
> what it broke.  When it actually does break something, I make it a priority
> to fix it, and if you have seen my lead time on real emergencies, its, like,
> what, 5 mins after the tinderbox got finished with it?
>
> I am sorry that the mv inserted by the maintainer caused such an
> international incident, maybe someone should edit portlint and look for
> ${MV} or \bmv\b ?
>
> No, stop wasting time, and start back to making FreeBSD the best choice,
> best operating system for discriminating system admins.

Hi Michael,

I recognise your concerns here, I really do.

However, portlint isn't designed to tell you if your code is broken or
not-- it's something you have to learn, and if necessary review with
others (I know you have a good record of asking for review).  Use of
${MV} isn't inherently wrong, it is just wrong here.

In this case, although it's not a international incident, it's still
incorrect code that needs fixing.  Please don't point to others as
precedent to ignore common practices-- if they have caused an issue,
take it up with them; don't follow their lead!

Chris