cvs commit: ports/www/trac Makefile ports/www/trac/files tracd.in

[Doug Barton]

maintainer, have you had a chance to look at these changes yet?

On 07/20/2011 23:05, Doug Barton wrote:
> I realize that you copied this script, but it has issues. :)  I know
> I've said it before, but this is why I'm so pedantic about reviewing the
> rc.d scripts, bad examples are copied, seemingly with more frequency
> than good ones. :-/
> 
> One of the issues with this script is that it's pretty convoluted.
> Therefore I _think_ I got everything working the way it did before, but
> it needs testing. Particularly the _trac_env stuff.
> 
> The single most important change is tracd_args -> tracd_flags. I don't
> know why this _args keeps slipping in, but it's not standard, and
> shouldn't be used. The advantage of _flags is that it's handled
> transparently by rc.subr.
> 
> Beyond that, I've removed the default empty variable assignments, they
> are not necessary or desirable, especially when you have such good
> documentation in the headers.
> 
> There are a variety of other simplifications, and I moved the
> environment settings into a start_precmd.
> 
> Like I said, this needs testing. If you have any questions, feel free to
> follow up to freebsd-rc at .
> 
> 
> Doug
> 
> 
> On 07/05/2011 17:26, Cheng-Lung Sung wrote:
>> clsung      2011-07-06 00:26:45 UTC
>>
>>   FreeBSD ports repository
>>
>>   Modified files:
>>     www/trac             Makefile 
>>   Added files:
>>     www/trac/files       tracd.in 
>>   Log:
>>   - Since trac can work as standalone http server, I copied rc script from old trac-multirepos port.
>>   - also fixed portlint warning about CONFLICTS line.
>>   
>>   PR:             ports/155295  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=155295
>>   Submitted by:   "Grzegorz Blach" <magik_AT_roorback dot net>
>>   
>>   Revision  Changes    Path
>>   1.54      +7 -3      ports/www/trac/Makefile
>>   1.1       +61 -0     ports/www/trac/files/tracd.in (new)
>>
>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/trac/Makefile.diff?&r1=1.53&r2=1.54&f=h
>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/trac/files/tracd.in
>>
> 
> 
> 



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/