cvs commit: ports/x11/xterm Makefile pkg-plist

[Emanuel Haupt]

On 21.09.2011, at 22:05, Doug Barton <dougb at FreeBSD.org> wrote:

> On 09/21/2011 12:08, Emanuel Haupt wrote:
>> Doug Barton <dougb at FreeBSD.org> wrote:
>>> On 09/21/2011 02:58, Emanuel Haupt wrote:
>>>> Peter Jeremy <peterjeremy at acm.org> wrote:
>>> 
>>>>> This is a bit belated but why does xterm need a hard dependency
>>>>> on gnome?  Could you please look at making this optional so that
>>>>> those of us who don't run bloatware can turn it off.
>>>> 
>>>> Good point. I've just committed a patch that makes the installation
>>>> of desktop entries conditional.
>>> 
>>> What isn't clear to me is why the installation of the desktop entry
>>> depends on gnome at all. Why not just install the file? I ask because
>>> (at least) xfce also uses the desktop entries, so having them is
>>> useful for non-gnome cases as well.
>> 
>> From what I understand "desktopfileutils" needs to be set in (USE|
>> WANT)_GNOME if there are *.desktop files installed. This is where some
>> gnome dependencies are pulled in.
> 
> Yes, I understand that this is your understanding, otherwise you
> wouldn't have done it that way. :)  I am attempting to challenge that
> understanding. IOW, can the installation of the desktop file be split
> out from the gnome desktopfileutils part?
> 
> The attached works for the non-gnome case, and the xterm.desktop file
> appears as expected for xfce.

Looks good. Feel free to commit, I am currently afk.

Emanuel




> 
> 
> Doug
> 
> -- 
> 
>    Nothin' ever doesn't change, but nothin' changes much.
>            -- OK Go
> 
>    Breadth of IT experience, and depth of knowledge in the DNS.
>    Yours for the right price.  :)  http://SupersetSolutions.com/
> 
> <xterm-desktop.diff>