cvs commit: ports/Mk bsd.cmake.mk ports/devel/cmake Makefile ports/devel/cmake/files patch-Modules_Compiler_GNU.cmake

[Dmitry Marakasov]

* Raphael Kubo da Costa (rakuco at FreeBSD.org) wrote:

>   - Pass default build flags (at least I hope) via bsd.cmake.mk.

That's not the best solution as it leads to cmake warnings:

---
CMake Warning: The variable, 'CMAKE_CXX_FLAGS_DEBUG', specified manually, was not used during the generation.
CMake Warning: The variable, 'CMAKE_C_FLAGS_DEBUG', specified manually, was not used during the generation.
CMake Warning: The variable, 'CMAKE_C_FLAGS_RELEASE', specified manually, was not used during the generation.
---

However, I've just ran into a variable that should solve the thing gracefully:

CMAKE_NOT_USING_CONFIG_FLAGS(=YES)

Even better, it affects all other configurations (RELWITHDEBINFO,
MINSIZEREL) and other variables (at least CMAKE_*_LINKER_FLAGS).

Quick testing shows that there are neiter foreign flags nor warnings in the logs.

Patch:

--- bsd.cmake.mk.patch begins here ---
Index: bsd.cmake.mk
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/Mk/bsd.cmake.mk,v
retrieving revision 1.10
diff -u -r1.10 bsd.cmake.mk
--- bsd.cmake.mk	11 Sep 2011 02:04:08 -0000	1.10
+++ bsd.cmake.mk	14 Sep 2011 04:27:17 -0000
@@ -53,14 +53,11 @@
 CMAKE_ARGS+=	-DCMAKE_C_COMPILER:STRING="${CC}" \
 				-DCMAKE_CXX_COMPILER:STRING="${CXX}" \
 				-DCMAKE_C_FLAGS:STRING="${CFLAGS}" \
-				-DCMAKE_C_FLAGS_DEBUG:STRING="${CFLAGS}" \
-				-DCMAKE_C_FLAGS_RELEASE:STRING="${CFLAGS}" \
 				-DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}" \
-				-DCMAKE_CXX_FLAGS_DEBUG:STRING="${CXXFLAGS}" \
-				-DCMAKE_CXX_FLAGS_RELEASE:STRING="${CXXFLAGS}" \
 				-DCMAKE_INSTALL_PREFIX:PATH="${CMAKE_INSTALL_PREFIX}" \
 				-DCMAKE_BUILD_TYPE:STRING="${CMAKE_BUILD_TYPE}" \
-				-DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES
+				-DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES \
+				-DCMAKE_NOT_USING_CONFIG_FLAGS:BOOL=TRUE
 
 #
 # Default build type and sourcedir
--- bsd.cmake.mk.patch ends here ---

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:  jabber: amdmi3 at jabber.ru    http://www.amdmi3.ru