cvs commit: ports/graphics/gegl Makefile

Alexey Dokuchaev danfe at FreeBSD.org
Tue Nov 22 16:19:26 UTC 2011


On Tue, Nov 22, 2011 at 04:15:53PM +0100, Pietro Cerutti wrote:
> On 2011-Nov-22, 14:27, Alexey Dokuchaev wrote:
> > On Tue, Nov 22, 2011 at 12:58:08PM +0000, Pietro Cerutti wrote:
> > > gahr        2011-11-22 12:58:08 UTC
> > > 
> > >   Modified files:
> > >     graphics/gegl        Makefile 
> > >   Log:
> > >   - Disable VALA support
> > 
> > Perhaps better message would be "Disable VALA support as it appears broken".
> 
> Yes, thanks a lot.

Perhaps a bit of explanation is in order.  Generally speaking, commit logs
should contain about 1/3 of description of what had been done and remaining
2/3 should be devoted to the reasoning (why was it done).

In this particular case, it's completely unclear what's exactly wrong with
VALA support that you'd had to disable it (although I definitely support
having generally useless stuff disabled by default); I'd had to look through
the PR to find mentions of build breakage.

./danfe


More information about the cvs-ports mailing list