cvs commit: ports/mail Makefile ports/mail/rspamd Makefile distinfo pkg-descr pkg-plist ports/mail/rspamd/files redirector.sh.in rspamd.sh.in

[Doug Barton]

Couple of problems with the rc.d scripts. The biggest problem is that 
new scripts should not be added with the .sh extension. So, pointy hat 
to az@ on that one. :)

For the redirector script:
We prefer that the name of the file, $name, and PROVIDE all match. So 
since this file has to be renamed anyway, it should be renamed to 
rspamd_redirector.in (and the corresponding change made in USE_RC_SUBR 
of course). Also, you're not supposed to set procname directly. You 
should just set command= at the top.

For the rspamd script:
Same procname problem, otherwise it looks fine.


hth,

Doug


On 02/02/2011 07:40, Vsevolod Stakhov wrote:
> vsevolod    2011-02-02 15:40:58 UTC
>
>    FreeBSD ports repository
>
>    Modified files:
>      mail                 Makefile
>    Added files:
>      mail/rspamd          Makefile distinfo pkg-descr pkg-plist
>      mail/rspamd/files    redirector.sh.in rspamd.sh.in
>    Log:
>    Add rspamd - fast and modular spam filtering system written in C
>    in event driven paradigma.
>
>    Reviewed by:    az
>    Feature safe:   yes
>
>    Revision  Changes    Path
>    1.1057    +1 -0      ports/mail/Makefile
>    1.1       +72 -0     ports/mail/rspamd/Makefile (new)
>    1.1       +2 -0      ports/mail/rspamd/distinfo (new)
>    1.1       +33 -0     ports/mail/rspamd/files/redirector.sh.in (new)
>    1.1       +52 -0     ports/mail/rspamd/files/rspamd.sh.in (new)
>    1.1       +5 -0      ports/mail/rspamd/pkg-descr (new)
>    1.1       +32 -0     ports/mail/rspamd/pkg-plist (new)
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/Makefile.diff?&r1=1.1056&r2=1.1057&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/Makefile
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/distinfo
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/files/redirector.sh.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/files/rspamd.sh.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/pkg-descr
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/pkg-plist
>



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/