cvs commit: ports/www/hiawatha Makefile ports/www/hiawatha/files hiawatha.in php-fcgi.in pkg-message.in

Greg Larkin glarkin at FreeBSD.org
Tue Aug 23 21:03:33 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/23/11 4:12 PM, Doug Barton wrote:
> The rc.d script looks good, thanks!
> 
> The only thing I would do differently is instead of having 2 separate lines:
> 
> : ${hiawatha_pidfile="/var/run/hiawatha.pid"}
> pidfile=${hiawatha_pidfile}
> 
> Do it like this:
> 
> pidfile=${hiawatha_pidfile="/var/run/hiawatha.pid"}
> 
> But that's really a micro-optimization.
> 
> 
> Thanks again,
> 
> Doug
> 

Nice job, Carlo!  We can add that change on the next hiawatha update.

Cheers,
Greg
- -- 
Greg Larkin

http://www.FreeBSD.org/           - The Power To Serve
http://www.sourcehosting.net/     - Ready. Set. Code.
http://twitter.com/cpucycle/      - Follow you, follow me
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5UDgAACgkQ0sRouByUApDUnwCeLlA3mrm+8bHB7f8tqSkmOZiP
lskAn0An2pU2ahPY4joFDWi4c68vINrd
=RrI1
-----END PGP SIGNATURE-----


More information about the cvs-ports mailing list