cvs commit: ports/www/chromium Makefile

Chris Rees crees at freebsd.org
Sun Aug 21 11:49:09 UTC 2011


2011/8/21 Alexey Dokuchaev <danfe at freebsd.org>:
> On Sun, Aug 21, 2011 at 12:04:37PM +0100, Chris Rees wrote:
>> On 21 August 2011 12:00, Rene Ladan <rene at freebsd.org> wrote:
>> > rene        2011-08-21 11:00:38 UTC
>> >
>> >  Modified files:
>> >    www/chromium         Makefile
>> >  Log:
>> >  Do not hardcode the patch directory as "files", use ${FILESDIR} instead.
>>
>> Shouldn't it be PATCHDIR?
>
> Ideally, only one should stay, I don't really care which one (although
> FILESDIR is maybe a bit better as it's more generic -- there might be not
> only patches, but drop-in files, etc).
>
> I wanted to look at merging FILESDIR/PATCHDIR logic in bpm several years
> ago, but didn't go much further.
>

I'd agree on FILESDIR.

Anyone have a problem with adding a section on
wiki/PortsLongtermTargets about ports that use PATCHDIR? This
inconsistency is a little strange.

Chris


More information about the cvs-ports mailing list