cvs commit: ports/games/alienarena Makefile distinfo pkg-descr pkg-message ports/games/alienarena/files alienarena-ded.in alienarena-sdl.in alienarena.in patch-Makefile patch-client__menu.c patch-game__acesrc__acebot.h patch-game__acesrc__acebot_nodes.c ...

[Alexey Dokuchaev]

On Tue, Mar 25, 2008 at 11:00:41AM +0100, Pav Lucistnik wrote:
> Alexey Dokuchaev p??e v ?t 25. 03. 2008 v 09:59 +0000:
> > On Mon, Mar 24, 2008 at 08:42:28PM +0000, Alejandro Pulver wrote:
> > >   Log:
> > >   Both data and program:
> > >   - Update to version 2008.
> > >   
> > >   Only for games/alienarena:
> > >   - Remove local patches (now integrated upstream).
> > >   - Check for WITH_* instead of !WITHOUT_* (avoid double negation).
> > 
> > I've been under impression that common practice is to check for WITH_FOO
> > with knobs that are default to off, and !WITHOUT_FOO that default to on.
> 
> No longer needed with OPTIONS.

Technically I would agree, but it breaks traditional convention and
consistency for little reason.  Doing it the old way also aids in reading
the Makefile, in a certain way.

./danfe