cvs commit: ports/www/lynx Makefile pkg-plist

[Alex Kozlov]

On Wed, Jul 02, 2008 at 09:16:05PM +0000, Alexey Dokuchaev wrote:
> On Wed, Jul 02, 2008 at 02:57:56PM +0000, Rong-En Fan wrote:
> > rafan       2008-07-02 14:57:56 UTC
> > 
> >   FreeBSD ports repository
> > 
> >   Modified files:
> >     www/lynx             Makefile pkg-plist 
> >   Log:
> >   - Use ncursesw if available
> >   - Use gzip for documents
> >   - OPTIONS'ify
> >   - Bump PORTREVISION
This is backport from lynx-current.

> I have a couple of questions:
> 
> - Is CONFIGURE_TARGET really necessary here? Is yes, could you elaborate
>   on why whould it be?
> - Exatra parameter --enable-nested-tables was added to CONFIGURE_ARGS,
>   but commit log does not mention it.  What changes does it bring?
It's allow to show table in table. By default lynx show only inner tables
in that case. In my opinion this is quite safe option.
Sorry for not mention it in description.

> - In OPTIONS, "Colors support" does not look very descriptive to me
> - Again in OPTIONS, "IPV6 support" should probably be speeled as IPv6
> - OPTIONS are badly indented
> - .if defined(WITH_IPV6) && ! defined(NO_INET6) -- superfluous space
>   after !
> - ENABLE_DEFAULT_COLORS should probably be dropped altogether (with
>   corresponding UPDARING note): we should not encourage non-standard
>   knobs (i.e. not starting with WITH/WITHOUT) in most cases
I agree, but someone may still have this knob in make.conf.
May be best course of action will be warning and then dropping knob in next
update.

> This is just what cathes the eye, it's not thorough review.


--
Adios