cvs commit: ports/print/acroread7 Makefile pkg-deinstall pkg-plist.7.0.1 pkg-plist.7.0.5 ports/print/acroread7/files pkg-install.in

[Jean-Yves Lefort]

On Sat, 20 May 2006 22:15:21 +0900 (JST)
Hiroki Sato <hrs at FreeBSD.org> wrote:

> Jean-Yves Lefort <jylefort at FreeBSD.org> wrote
>   in <20060519090956.4f19dd41.jylefort at FreeBSD.org>:
> 
> jy> With that interpretation the port is also illegal since it's not only
> jy> a "new installer", but also "modifies the Software" (through brandelf,
> jy> for instance):
> jy>
> jy> "You may not otherwise alter or modify the Software or create a new
> jy> installer for the Software."
> 
>  I think neither the port is a new installer nor it modifies the Software,
>  and I think pkg-install script in your patch modifies the installed file.
>  This is my opinion as the port maintainer.
> 
> jy> Can I fix pkg-deinstall by checking if $PKG_PREFIX/Adobe/Acrobat7.0 is
> jy> empty after deinstallation?
> 
>  Why do you force me on your idea?

I'm not forcing you, I just added a new point to the discussion
(according to your interpretation, the port already violates the
license) and asked you to reconsider in light of that addition.

>  I do not like using
>  pkg-install/pkg-deinstall to install the desktop entry
>  in the master port, and I think it should be done by using
>  symlink or so in another port (print/acroreadwrapper or new one),
>  or something like acroreadwrapper's --install-plugin option.
>  We also have to consider mixing of version 7.0.5 and 7.0.1.
> 
>  I can understand installing the desktop entry and the icon file
>  is a good thing (IIRC, netchild@, mezz@, and I discussed this
>  topic before), but at least I have not approved your patch and
>  do not accept the installation/deinstallation scripts you committed.

You have approved it:

Approved by:	maintainer timeout (17 days)

Since you have changed your mind, I'll no longer annoy you with this.
FYI, installing the .desktop file is desirable not only because of the
menu item, but also because it associates the application/pdf MIME
type with acroread, so that users don't have to do it manually.

-- 
Jean-Yves Lefort

jylefort at FreeBSD.org
http://lefort.be.eu.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20060520/11136b59/attachment.pgp