cvs commit: ports/net/rdesktop pkg-plist

Alexey Dokuchaev danfe at FreeBSD.org
Fri Mar 11 02:52:26 PST 2005


On Thu, Mar 10, 2005 at 02:19:06PM -0500, Adam Weinberger wrote:
> >> (03.10.2005 @ 1409 PST): Florent Thoumie said, in 1.2K: <<
> > David E. O'Brien wrote:
> > >obrien      2005-03-10 19:05:11 UTC
> > >
> > >  FreeBSD ports repository
> > >
> > >  Modified files:
> > >    net/rdesktop         pkg-plist
> > >  Log:
> > >  Sort the keymaps.
> > >
> > >  Revision  Changes    Path
> > >  1.5       +32 -32    ports/net/rdesktop/pkg-plist
> > 
> > 	This is your third commit to get rdesktop updated
> > 	in two days.
> > 
> > 	There was a PR pending with a patch included. Maintainer
> > 	has been cc'ed.
> > 
> > 	Please respect ownership when not working on your ports,
> > 	or at least wait for maintainer timeout before applying
> > 	your changes.
> >> end of "Re: cvs commit: ports/net/rdesktop pkg-plist" from Florent Thoumie <<
> 
> Sorting the pkg-plist is a trivial change, and was the maintainer's
> responsibility in the first place. Asking for maintainer approval
> for trivial fixes supports a level of bureaucracy that, while nice
> in concept, simple prevents people from applying trivial fixes.
> 
> Note that I'm not commenting on David's other commits to rdesktop;
> I haven't looked at them. Note also that I do not know what is in
> the PR. My only argument here is that committers should not feel
> like applying trivial fixes and routine maintenance to the ports
> tree amounts to stepping on someone's toes.

The problem is that you'll never know all cases.  Sometimes a simple
change might cause a problem, and instead of guessing, it's always good
idea to check with maintainer.  Just leaves no room for misunderstanding
and feeling that ones maintainer status is being ignored.

./danfe


More information about the cvs-ports mailing list