cvs commit: ports/lang/gcc34 Makefile

[Gerald Pfeifer]

On Sat, 20 Mar 2004, David O'Brien wrote:
> Actually this is a bug in your pkg-plist.  I just tested this with your
> latest commits (Makefile rev 1.166, pkg-plist rev 1.55).  This patch
> (which I just committed) makes the existing breakage obvious:
>
>   @dirrm libexec/gcc/%%GNU_HOST%%/%%GCC_VER%%
>  + at dirrm libexec/gcc/%%GNU_HOST%%
>  + at dirrm libexec/gcc
>   %%LIBJAVA%%share/java/libgcj-%%GCC_VER%%.jar

Won't this break if more than gcc3x port has been installed?  (I'll
shortly mark them as CONFLICTing, but in the longer term this should
work.)

> If you look at ports/Mk/bsd.port.mk, you'll see that CONFIGURE_TARGET is
> defined as ${MACHINE_ARCH}-portbld-freebsd${OSREL}, which is effectively
> the same as the definition I removed and you re-added.

I know that, and in fact I had tried something similar to your original
patch a few weeks ago. :->   That's why I immediately got alerted when
seeing your patch.

> Can we agree to this patch now?
>
>       .if ${ARCH} == "amd64"
>       CONFIGURE_TARGET=      x86_64-portbld-freebsd${OSREL}
>      -.else
>      -CONFIGURE_TARGET=      ${ARCH}-portbld-freebsd${OSREL}
>       .endif

Sure, iff it survives full testing (including a `make deinstall` that
really removes all files installed by the port).

Gerald
-- 
Gerald Pfeifer (Jerry)   gerald at pfeifer.com   http://www.pfeifer.com/gerald/