cvs commit: ports/devel/portlint Makefile ports/devel/portlint/src portlint.pl

[Joe Marcus Clarke]

On Sun, 2004-06-06 at 14:11, Oliver Eikemeier wrote:
> Joe Marcus Clarke wrote:
> 
> > On Sun, 2004-06-06 at 13:13, Oliver Eikemeier wrote:
> > 
> >>Joe Marcus Clarke wrote:
> >>
> >>>This was supposed to solve a problem that I've personally hit a few
> >>>times.  It was just another check to make sure PKGNAME agrees with what
> >>>is in distinfo.
> >>
> >>Could you give me an example? It might be interesting to add this to my
> >>rework of the distfiles stuff in PR 67361:
> >>  <http://people.freebsd.org/~eik/patches/distfiles/>
> >>
> >>If it is deemed useful to integrate distinfo into the ports Makefile one 
> >>way or the other, it might not be worth to make efforts to check for 
> >>stuff that might be obsolete in the future.
> > 
> > For instance, when fixing hyphenated PORTNAMEs, I sometimes forget to
> > adjust DISTNAME, and thus the port is broken.  I always remember a
> > portlint run, but it would never catch the problem.
> > 
> > Joe
> 
> So you need a consistency check without fetching the actual distfiles?
> I guess it makes sense to include this into bsd.port.mk, since the
> involved code is non-trivial, but the logic is already in place. Should
> I add a target to my patch, and what kind of output do you expect?

If it's added to bsd.port.mk, then that target should be called by
portlint.  I guess it would be better to put it in b.p.m since it could
be used by more scripts that way.

Joe

> 
> -Oliver
-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20040606/490caaed/attachment.bin