cvs commit: ports/security/amavisd-new Makefile distinfo pkg-plist ports/security/amavisd-new/files INSTALL.tmpl MESSAGE.tmpl amavisd.sh.tmpl patch-amavisd patch-amavisd-sample.conf patch-amavisd.conf perlwarning.tmpl

[Joshua Goodall]

Hi

I found three problems with the latest amavisd-new port:

On Sun, Jul 18, 2004 at 10:05:50AM +0000, Vanilla I. Shu wrote:
>   - remove taint checks when running perl 5.00503

Was this actually tested on 5.00503, though? This version of
amavisd-new doesn't even start up on a stock 4.10-RELEASE
box I have here:

root at server:~# /usr/local/etc/rc.d/amavisd.sh start
Starting amavisd.
Can't locate warnings.pm in @INC (@INC contains: /usr/local/lib/perl5/site_perl/5.005/i386-freebsd /usr/local/lib/perl5/site_perl/5.005 . /usr/libdata/perl/5.00503/mach /usr/libdata/perl/5.00503) at /usr/local/sbin/amavisd line 1549.
BEGIN failed--compilation aborted at /usr/local/sbin/amavisd line 1549.

because there is no 'use warnings / no warnings' option in 5.00503.

The following message isn't sufficient:
-------------------------------------------------------------------
 WARNING: You appear to be running perl version 5.00503.

 amavisd-new has been tested and is guaranteed to run only with
 perl 5.8.2 and above. There are numerous problems with amavisd-new
 when running under previous perl versions, including perl crashes,
 taint bugs and others.  You are strongly advised to upgrade your
 perl by using the /usr/ports/lang/perl5.8 port.
-------------------------------------------------------------------
If you require 5.8.2, you should depend on it explicitly. I didn't
even see this warning first time around; it scrolled away.


There also appears to be a missed substitution;
root at server:/usr/ports/security/amavisd-new# grep %%PREFIX%% /usr/local/sbin/amavisd 
my($config_file) = '%%PREFIX%%/etc/amavisd.conf';  # default location of config file

Although possibly this is because you've concatenated amavisd to itself
in the port Makefile thanks to the >> in line 109 vs line 103:
root at server:/usr/ports/security/amavisd-new# ls -l work/amavisd-new-20040701/amavisd work/amavisd
-rw-r--r--  1 root  wheel  967063 Aug 11 20:59 work/amavisd
-rwxr-xr-x  1 root  wheel  483533 Aug 11 20:59 work/amavisd-new-20040701/amavisd


Finally, the package needs to mkdir+chmod+chown /var/amavis/tmp:
Aug 11 20:57:47 server amavis[88769]: TROUBLE in pre_loop_hook: TEMPBASE directory is not writable: /var/amavis/tmp at /usr/local/sbin/amavisd line 5543.


Please fix :)

Thanks!
Joshua.