cvs commit: doc/en_US.ISO8859-1/share/sgml authors.ent

[Ulrich Spörlein]

On Fri, 04.06.2010 at 11:00:16 -0700, Doug Barton wrote:
> On 06/04/10 10:30, Matthew D Fleming wrote:
> > mdf         2010-06-04 17:30:47 UTC
> >
> >    FreeBSD doc repository (src committer)
> >
> >    Modified files:
> >      en_US.ISO8859-1/share/sgml authors.ent
> >    Log:
> >    Add myself to the list of committers.
> >
> >    Revision  Changes    Path
> >    1.509     +2 -0      doc/en_US.ISO8859-1/share/sgml/authors.ent
> >
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/doc/en_US.ISO8859-1/share/sgml/authors.ent.diff?&r1=1.508&r2=1.509&f=h
> 
> Matthew,
> 
> Couple of things ... first, welcome to the fun! Second, (and your mentor 
> really should be filling you in on this stuff) it's customary for 
> related commits in the same tree to go in together. So rather than 
> committing these doc updates one at a time it would have been better to 
> get all the related stuff in one go. Also, until you're released from 
> mentorship ALL of your commits should indicate that they were approved 
> by your mentor (which implies of course that zml reviews them first).

The handbook is somewhat misleading in this regard, as it warns you that
the www build may break if stuff happens in the wrong order. People may
therefore opt to err on the side of caution by putting stuff in
sequentially.

Uli