cvs commit: ports/mail/rubygem-mail Makefile distinfo

[Eric]

> From: Sahil Tandon <sahil at FreeBSD.org>
> Date: Tue, 26 Jul 2011 20:43:50 -0400
> 
>> On Tue, 2011-07-26 at 17:32:34 -0700, Doug Barton wrote:
> 
>>> On 07/26/2011 10:00, Philip M. Gollucci wrote:
>>> Normally, I 100% agree with Doug.  But we're not only talking about ruby
>>>  here, we're talking about rails.  I hard a hard time naming gems that
>>> don't do this crap.  I almost replied yesterday and said add an option,
>>> but IMHO either way is fine, and not worth diddling over.
>> 
>> There are at least 3 possible ways to handle this situation:
>> 
>> 1. Force the dependency
> 
> I hope we can avoid this.
> 
>> 2a. Have an OPTION and error out if the user chooses WITHOUT_FOO and foo
>> is installed.
> 
> For what (little) it's worth, my vote is for 2a.

Well it is probably the cleanest route to reflect the situation.  If I have
time I will try to create some suitable logic to perform this at the weekend
(little snowed under this week), unless Doug (or anyone else) has something
in mind and has the time to file a PR?

>> 2b. Have an OPTION and patch the distfiles if the user chooses
>> WITHOUT_FOO and foo is installed.
>> 
>> Personally I don't care which option is used, but IMO the problem of
>> ports silently growing dependencies based on what is installed on the
>> system has to be solved.
>> 

I'm still not sure* we are silently growing dependencies in this case.
There is an interaction between the the mail gem and the activerecord gem,
but the mail gem does not have a hard dependency on activerecord, it uses it
if found, if not found it doesn't break but continues working.  So there
would (should) be no problem with a user adding or removing activerecord as
they wanted without affecting the apparent functionality of the mail gem**.

Regards

Eric


* and I will have to confess to being far less experienced in ports
internals than Doug here, so will defer to his more experienced view on this
matter.

** personally I'm not sure the way the author has done things is ideal since
they have created a situation where an apparent bug in the mail gem may or
may not be caused by an incompatible future version of activerecord.