cvs commit: ports/www/tomcat55 Makefile ports/www/tomcat55/files logprocessor-cronolog tomcat55.sh.in

[Doug Barton]

This rc.d script still has a lot of problems. The biggest being that it
runs a lot of code in the body of the script, which we like to avoid
doing. I started to take a crack at it, but there are more things here
that need attention than I have time for.

All of the stuff that updates the environment needs to be in a function.
Assuming that they are only needed at start time, a prestart function
should do the trick. If they are needed for start and stop then name it
something like tomcat_env() and call it in both places.

I'm not sure where to start on the pidfile stuff, since it's not clear
to me what's being attempted. It should likely be isolated into a
start_precmd.

Rather than using cd directly in the script as it does in the second to
last line, look at ${name}_chdir from rc.subr.

If you need help with this stuff, feel free to follow up to freebsd-rc at .


hth,

Doug


On 07/19/2011 15:45, Olli Hauer wrote:
> ohauer      2011-07-19 22:45:27 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www/tomcat55         Makefile 
>     www/tomcat55/files   tomcat55.sh.in 
>   Removed files:
>     www/tomcat55/files   logprocessor-cronolog 
>   Log:
>   - fix cronolog processing option [1]
>   - improve pidfile handling in rc script [2]
>   
>   PR:             ports/158237 [1], ports/158410 [2]  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=158237
>   Submitted by:   Jason Helfman <jhelfman _at_ experts-exchange.com> (maintainer) [1]
>                   Phil Phillips <pphillips _at_ experts-exchange.com> [2]
>   Approved by:    maintainer
>   
>   Revision  Changes    Path
>   1.59      +7 -15     ports/www/tomcat55/Makefile
>   1.2       +0 -74     ports/www/tomcat55/files/logprocessor-cronolog (dead)
>   1.11      +8 -19     ports/www/tomcat55/files/tomcat55.sh.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/tomcat55/Makefile.diff?&r1=1.58&r2=1.59&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/tomcat55/files/logprocessor-cronolog
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/tomcat55/files/tomcat55.sh.in.diff?&r1=1.10&r2=1.11&f=h
> 



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/