cvs commit: ports/security/ipsec-tools Makefile
ports/security/ipsec-tools/files racoon.sh.in
John Hein
jhein at symmetricom.com
Tue Jul 19 16:00:08 UTC 2011
Doug Barton wrote at 01:39 -0700 on Jul 19, 2011:
> This change is an improvement, but it doesn't go far enough in a couple
> of directions. The 2 most important being that faststart is not the only
> possible prefix there, and we don't want that block to run
> unconditionally in any case.
>
> I've attached the full script I'm suggesting because the diff doesn't
> make much sense. One thing I didn't change because I'm not sure if it
> needs to be run early is changing the current require/before to just
> REQUIRE: LOGIN, which is what we prefer ports scripts to do. However if
> there is a good reason for this one to run earlier, that's fine.
>
> If you have any questions, let me know.
Yes, looks good to me. Well, except the spelling issues:
sed -E 's,(raccon|raccoon),racoon,g'
I'm not sure if there are some lurking subtleties regarding the
require/before question. I'll let Yvan answer that. Commit
history doesn't say anything - it's been REQUIRE: DAEMON &
BEFORE: LOGIN since the beginning - probably just copy/pasted.
More information about the cvs-all
mailing list