cvs commit: ports/dns/opendnssec Makefile distinfo pkg-plist ports/dns/opendnssec/files opendnssec.in

[Doug Barton]

Jaap,

I've attached some (hopefully) improvements to the rc.d script. First
the minor issues:

1. It needs a $FreeBSD$
2. We prefer ports scripts to REQUIRE: LOGIN unless there is a reason it
needs to start earlier.
3. Minor typo and whitespace twiddles

More substantively, I compressed the start_ and stop_ methods, but this
should be tested. It certainly _should_ work. :) It's fine to have all
the extra_commands, but they won't be functional unless they also have
methods associated with them. Finally, I left the procname assignment in
there, but it's not at all clear to me where $opendnssec_procname is
defined, or what that procname is going to be used for. It can probably
just be deleted.


hth,

Doug


On 07/15/2011 13:55, Julien Laffaye wrote:
> jlaffaye    2011-07-15 20:55:00 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     dns/opendnssec       Makefile distinfo pkg-plist 
>   Added files:
>     dns/opendnssec/files opendnssec.in 
>   Log:
>   Update to 1.3.0
>   
>   PR:             ports/158865  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=158865
>   Submitted by:   Jaap Akkerhuis <jaap at NLnetLabs.nl> (maintainer)
>   Approved by:    bapt (mentor)
>   
>   Revision  Changes    Path
>   1.11      +29 -5     ports/dns/opendnssec/Makefile
>   1.10      +2 -2      ports/dns/opendnssec/distinfo
>   1.1       +42 -0     ports/dns/opendnssec/files/opendnssec.in (new)
>   1.6       +2 -1      ports/dns/opendnssec/pkg-plist
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/dns/opendnssec/Makefile.diff?&r1=1.10&r2=1.11&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/dns/opendnssec/distinfo.diff?&r1=1.9&r2=1.10&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/dns/opendnssec/files/opendnssec.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/dns/opendnssec/pkg-plist.diff?&r1=1.5&r2=1.6&f=h
> 



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/

-------------- next part --------------
Index: opendnssec.in
===================================================================
RCS file: /home/pcvs/ports/dns/opendnssec/files/opendnssec.in,v
retrieving revision 1.1
diff -u -r1.1 opendnssec.in
--- opendnssec.in	15 Jul 2011 20:55:00 -0000	1.1
+++ opendnssec.in	15 Jul 2011 22:51:59 -0000
@@ -1,16 +1,14 @@
 #!/bin/sh
-#
-# 
+
+# $FreeBSD$
 #
 # PROVIDE: opendnssec
-# REQUIRE: DAEMON
+# REQUIRE: LOGIN
 # KEYWORD: shutdown
 #
-# Add the following line to /etc/rc.conf to enable nsd:
+# Add the following line to /etc/rc.conf to enable opendnssec:
 #
 # opendnssec_enable="YES"
-#
-
 
 . /etc/rc.subr
 
@@ -19,24 +17,17 @@
 
 load_rc_config $name
 
-opendnssec_enable=${opendnssec_enable-"NO"}
+opendnssec_enable=${opendnssec_enable:-"NO"}
 
-start_cmd="${name}_start"
-stop_cmd="${name}_stop"
+start_cmd="${name}_run $1"
+stop_cmd="${name}_run $1"
 extra_commands="reload ksm hsm signer enforcer"
 
 procname=${opendnssec_procname}
 
-
-opendnssec_start()
+opendnssec_run()
 {
-    %%PREFIX%%/sbin/ods-control start
-}
-
-opendnssec_stop()
-{
-    %%PREFIX%%/sbin/ods-control stop
+    %%PREFIX%%/sbin/ods-control $1
 }
 
 run_rc_command "$1"
-