cvs commit: ports/sysutils/atop Makefile distinfo
ports/sysutils/atop/files atop.in pkg-message.in
Doug Barton
dougb at FreeBSD.org
Mon Jul 4 07:51:08 UTC 2011
On 07/03/2011 05:07, Alex Samorukov wrote:
> Hello,
>
> Thank you for comments.
>
> On 07/03/2011 02:33 AM, Doug Barton wrote:
>> Overall this looks good, just 2 small comments. It's not clear why it
>> uses:
>>
>> # REQUIRE: DAEMON
>> # BEFORE: LOGIN
>>
>> Instead of just
>>
>> # REQUIRE: LOGIN
>>
>> like most ports scripts do.
> Probably my copypaste from some other script. Better to replace with
> REQUIRE: LOGIN.
>
> > Also the default empty assignment for _flags is neither necessary or
> desirable.
>
> Agree. Do i need to submit PR to fix this or you can do it without it?
All set, thanks. :)
--
Nothin' ever doesn't change, but nothin' changes much.
-- OK Go
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
More information about the cvs-all
mailing list