cvs commit: ports/security/fprint_demo Makefile distinfo pkg-plist

[Wesley Shields]

On Fri, Dec 02, 2011 at 02:16:32PM +0000, Michael Scheidell wrote:
> -----Original Message-----
> From: Wesley Shields [mailto:wxs at FreeBSD.org] 
> Sent: Friday, December 02, 2011 9:01 AM
> To: Michael Scheidell
> Cc: ports-committers at FreeBSD.org; cvs-ports at FreeBSD.org; cvs-all at FreeBSD.org
> Subject: Re: cvs commit: ports/security/fprint_demo Makefile distinfo pkg-plist
> 
> You didn't document this change in the commit log. :(
> 
> I know.. had two of these, pam_fprint and this one.
> 
> I thought I committed a BROKEN fprint_demo, and thought I was just
> committing fixes.

As a new committer you may not be familiar with the ways you can check
your work before committing. I recommend using "cvs status" and being
careful when checking what I'm committing.

Ultimately, no major harm here so no foul. I'm just trying to be helpful
to a new committer. :)

> > | --- ports/security/fprint_demo/distinfo	2011/11/29 12:59:55	1.3
> > | +++ ports/security/fprint_demo/distinfo	2011/11/29 22:39:55	1.4
> > | @@ -1,2 +1,4 @@
> > | -SHA256 (fprint-demo_20080303+git.orig.tar.gz) = 
> > | fcff7f6e8d61b253b88dd87ecf5cdb5418ecf11178ce7cb6ae0e350485045232
> > | -SIZE (fprint-demo_20080303+git.orig.tar.gz) = 77714
> > | +SHA256 (fprint-demo_20080303git.orig.tar.gz) = 
> > | +fcff7f6e8d61b253b88dd87ecf5cdb5418ecf11178ce7cb6ae0e350485045232
> > | +SIZE (fprint-demo_20080303git.orig.tar.gz) = 77714 
> > | +#http://mirrors.arsc.edu/ubuntu/packages/pool/
> > | +#universe/f/fprint-demo/fprint-demo_20080303git.orig.tar.gz
> 
> Are these last two lines really meant to be there?
> 
> Mostly to document that its in a STRANGE place (pam_fprint is in
> _20080203+git)

Not where I would put it. I'd put this information in the Makefile along
with a comment explaining it. Again, no major harm and this is your port
but the norm is to keep this information in Makefile and leave distinfo
for recording size and checksums only.

-- WXS