cvs commit: ports/www/chromium Makefile

[b. f.]

On 4/8/11, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> On Fri, Apr 08, 2011 at 03:47:07AM +0000, b. f. wrote:
>> On 4/8/11, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>> > On Fri, Apr 08, 2011 at 02:24:59AM +0000, Alexey Dokuchaev wrote:

> One can always pass desired CPUTYPE is they want to build their package
> with specific target.  As for amd64, here I agree, checking for ARCH

Yes, although obviously passing a CPUTYPE won't make a difference if
SSE2 is disabled whenever PACKAGE_BUILDING is defined.  Looking again
at bsd.cpu.mk and ports/Tools/portbuild/scripts/buildenv, it seems
that a maximally-compatible baseline CPUTYPE and MACHINE_CPU for each
architecture is defined for package-building machines using portbuild,
so the current chromium Makefile should be okay for them.  But the
same is not necessarily true of all tinderboxes or ad hoc
package-building machines.  I guess that we should just trust users to
configure them properly.

...

> On the other hand, Chromium is web browser, which it most likely is going
> to be used on users' desktop, where SSE2 is probably feels like home for
> a while already.  :-)

... for those people with new hardware.  But there are still quite a
few desktop machines that don't have SSE2, but can run modern
web-browsers, and these machines frequently use packages built
elsewhere.  I have a couple myself.

b.