cvs commit: ports/www/chromium Makefile

[Alexey Dokuchaev]

On Fri, Apr 08, 2011 at 12:53:27AM +0000, b. f. wrote:
> On 4/7/11, Rene Ladan <rene at freebsd.org> wrote:
> > rene        2011-04-07 22:39:09 UTC
> >
> >   FreeBSD ports repository
> >
> >   Modified files:
> >     www/chromium         Makefile
> >   Log:
> >   Cleanup Makefile a bit more:
> >   - Convert two explicit dependencies to a USE_GNOME and USE_XORG component
> >   - Use buildtime SSE2 detection instead of an OPTION
> 
> How is this last change above going to work for building i386
> packages, if the package-building machine has SSE2, but other machines
> that use the packages do not? (Or vice versa, for that matter.)  You
> may add some sanity checks, and make the effect of the option
> i386-specific, but I don't think that you can safely remove this
> option entirely --  and the default setting has to allow packages to
> work on all i386.

I've been thinking about this as well.  However, instead of bringing back
this OPTION, I'd suggest addind "|| defined(PACKAGE_BUILDING)" to that
.if to ensure that packages are can be safely run on pre-SSE2 CPUs.

./danfe