cvs commit: ports/irc/iroffer-dinoex Makefile distinfo ports/irc/iroffer-dinoex/files iroffer-dinoex.in

[Doug Barton]

A few problems with the rc.d script. Please see
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html
for more information.

1. The file name should match PROVIDE and $name
2. /etc/rc.subr does not need to be in quotes
3. Empty variable assignments are neither useful nor desirable (ala
_flags and command_args)
4. There are a couple of places where tests are written like this:
[ "${iroffer_dir}" != "" ]
They should be changed to [ -n "$iroffer_dir" ]
5. In iroffer_checkdisk() you use echo ... exit. You should use err()
instead. See examples in /etc/rc.d.


hth,

Doug


On 05/08/10 12:50, Dirk Meyer wrote:
> dinoex      2010-05-08 19:50:14 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     irc/iroffer-dinoex   Makefile distinfo 
>   Added files:
>     irc/iroffer-dinoex/files iroffer-dinoex.in 
>   Log:
>   - update to 3.21
>   - add rc.d script
>   
>   Revision  Changes    Path
>   1.14      +2 -2      ports/irc/iroffer-dinoex/Makefile
>   1.9       +3 -3      ports/irc/iroffer-dinoex/distinfo
>   1.1       +57 -0     ports/irc/iroffer-dinoex/files/iroffer-dinoex.in (new)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/iroffer-dinoex/Makefile.diff?&r1=1.13&r2=1.14&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/iroffer-dinoex/distinfo.diff?&r1=1.8&r2=1.9&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/iroffer-dinoex/files/iroffer-dinoex.in
> 



-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/