cvs commit: ports/graphics/dri Makefile

Robert Noland rnoland at FreeBSD.org
Thu Mar 25 15:10:10 UTC 2010



Marius Strobl wrote:
> On Thu, Mar 25, 2010 at 02:22:37PM +0100, Gary Jennejohn wrote:
>> On Thu, 25 Mar 2010 13:50:12 +0100
>> Marius Strobl <marius at alchemy.franken.de> wrote:
>>
>>> On Thu, Mar 25, 2010 at 05:59:37AM -0500, Robert Noland wrote:
>>>> On Tue, 2010-03-23 at 16:55, Marius Strobl wrote:
>>>>> On Mon, Mar 22, 2010 at 05:05:06AM +0000, Mark Linimon wrote:
>>>>>> linimon     2010-03-22 05:05:06 UTC
>>>>>>
>>>>>>   FreeBSD ports repository
>>>>>>
>>>>>>   Modified files:
>>>>>>     graphics/dri         Makefile 
>>>>>>   Log:
>>>>>>   Mark as broken on ia64 and sparc64: fails to install.
>>>>>>   
>>>>>>   Hat:            portmgr
>>>>>>   
>>>>> The following patch fixes the powerpc [sic] and sparc64 build of the
>>>>> default Mesa3D 7.4.4 after the 7.6.1 integration:
>>>>> http://people.freebsd.org/~marius/mesa3d_7.6.1_unbreak.diff
>>>>> Is it okay to commit?
>>>> Looks good to me, this will save me some work now that I have both a
>>>> powerpc and sparc64 boxes to play with.  In looking at mesa git, I think
>>>> I'll be making a few changes shortly...
>>>>
>>> So could someone please either approve or commit it (I have only
>>> a src bit).
>>>
>> Looks to me like Robert already approved it.
> 
> I think interpreting his comment as an "Approved by:" rather than
> a "Reviewed by:" would be stretching it a bit too much.

This was intended to be an approval, I'll follow on with some additional 
fixes, but let's get this committed first.  Anyway...

Approved by:	rnoland@

robert.

>> Having only a src commit bit shouldn't prevent your making a ports commit.
>> I've seen ports committers make src commits.
>>
> 
> Sure, but you always need an explicit approval for committing to
> a repository you don't have a bit for (at least so I've been told).
> 
> Marius
> 


More information about the cvs-all mailing list